-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ID Token sign in with Google SDK #3515
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3515 +/- ##
==========================================
- Coverage 78.41% 78.40% -0.01%
==========================================
Files 340 340
Lines 22533 22533
==========================================
- Hits 17669 17667 -2
- Misses 3556 3557 +1
- Partials 1308 1309 +1
|
var _ NonceValidationSkipper = new(ProviderGoogle) | ||
|
||
func (a *ProviderGoogle) CanSkipNonce(c *Claims) bool { | ||
return true // TODO!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause Ory to only validate nonce
s for Google if the ID Token from Google contains a nonce.
Since the SDKs I saw, don't support setting nonce
s, this is the best solution I can come up, without excluding a bunch of SDKs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this is fine for me. Please document this as a caveat though when writing docs for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted it to only return true, if no nonce is present in the claims.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue with the HTTP client (it is not using the SSRF protected HTTP client). Otherwise LGTM
Docs PR: ory/docs#1540 |
This PR adds support for social sign in via Google using an ID token instead of the browser based OIDC flows. This allows integration of the SDK for Google sign in on Android & iOS.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments