-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: one-time code native flows #3516
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3516 +/- ##
=======================================
Coverage 78.20% 78.20%
=======================================
Files 341 341
Lines 22767 22772 +5
=======================================
+ Hits 17804 17809 +5
Misses 3624 3624
Partials 1339 1339
|
13b19fa
to
6a15497
Compare
All e2e tests are failing :/ |
6a15497
to
6a0d699
Compare
hmm i'll have to take a look tomorrow. We still need to get the latest changes of Elements in AX for the best experience though, so this shouldn't be merged yet. |
Code tests are still failing :( What can I do to help get this over the finishing line? |
the tests are failing because we need some changes in ory elements ory/elements#150 |
e91aa7e
to
8ee5243
Compare
5f0aa09
to
44eb59a
Compare
Related issue(s)
Adds Go tests and E2E cypress tests to the native login and registration via code APIs.
Improves the UX of login and registration by hiding the input fields on the second (
email_sent
) state. This preserves the nodes in the API allowing the consumer to still display the fields however they would like. In the Account Experience these fields won't show up to the end-user and will be submitted along with the code.Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments