Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: one-time code native flows #3516

Merged
merged 11 commits into from
Oct 2, 2023
Merged

feat: one-time code native flows #3516

merged 11 commits into from
Oct 2, 2023

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Sep 15, 2023

Related issue(s)

Adds Go tests and E2E cypress tests to the native login and registration via code APIs.

Improves the UX of login and registration by hiding the input fields on the second (email_sent) state. This preserves the nodes in the API allowing the consumer to still display the fields however they would like. In the Account Experience these fields won't show up to the end-user and will be submitted along with the code.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #3516 (3325ce7) into master (6b91dc1) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is 86.58%.

❗ Current head 3325ce7 differs from pull request most recent head 85f5f81. Consider uploading reports for the commit 85f5f81 to get more accurate results

@@           Coverage Diff           @@
##           master    #3516   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files         341      341           
  Lines       22767    22772    +5     
=======================================
+ Hits        17804    17809    +5     
  Misses       3624     3624           
  Partials     1339     1339           
Files Coverage Δ
identity/test/pool.go 100.00% <100.00%> (ø)
selfservice/strategy/code/strategy.go 81.53% <100.00%> (+0.73%) ⬆️
identity/handler.go 85.32% <50.00%> (ø)
persistence/sql/identity/persister_identity.go 80.68% <81.39%> (ø)

@Benehiko Benehiko force-pushed the feat-one-time-code-native branch 4 times, most recently from 13b19fa to 6a15497 Compare September 25, 2023 07:45
@Benehiko Benehiko self-assigned this Sep 25, 2023
@Benehiko Benehiko marked this pull request as ready for review September 25, 2023 07:47
@aeneasr
Copy link
Member

aeneasr commented Sep 25, 2023

All e2e tests are failing :/

@Benehiko
Copy link
Contributor Author

hmm i'll have to take a look tomorrow. We still need to get the latest changes of Elements in AX for the best experience though, so this shouldn't be merged yet.

@aeneasr
Copy link
Member

aeneasr commented Sep 28, 2023

Code tests are still failing :(

What can I do to help get this over the finishing line?

@Benehiko
Copy link
Contributor Author

the tests are failing because we need some changes in ory elements ory/elements#150
I'm working on it. But tbh the PR can be reviewed already

@Benehiko Benehiko force-pushed the feat-one-time-code-native branch from e91aa7e to 8ee5243 Compare September 28, 2023 09:52
@Benehiko Benehiko force-pushed the feat-one-time-code-native branch from 5f0aa09 to 44eb59a Compare September 29, 2023 14:53
@Benehiko Benehiko requested a review from jonas-jonas October 2, 2023 12:46
@aeneasr aeneasr merged commit 9b0fee3 into master Oct 2, 2023
26 checks passed
@aeneasr aeneasr deleted the feat-one-time-code-native branch October 2, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants