feat: add flow internal context into webhook context #3840
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3840 +/- ##
==========================================
- Coverage 78.10% 78.01% -0.09%
==========================================
Files 362 359 -3
Lines 25329 25191 -138
==========================================
- Hits 19783 19653 -130
- Misses 4028 4032 +4
+ Partials 1518 1506 -12 ☔ View full report in Codecov by Sentry. |
aeneasr
reviewed
Mar 24, 2024
| RequestURL: x.RequestURL(req).String(), | ||
| RequestCookies: cookies(req), | ||
| Identity: session.Identity, | ||
| Flow: flow, |
There was a problem hiding this comment.
Isn't the internal context already available in the flow object itself? Or is it hidden in there?
There was a problem hiding this comment.
Yes, it's part of the flow object, but it does not serialise into json:
kratos/selfservice/flow/login/flow.go
Line 86 in 43e4ead
(cherry picked from commit ee4d463)
splaunov
force-pushed
the
feature/feat-ps-261
branch
from
07b59ed to
6ad618e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds data from `flow.internal_context' field into the context of Jsonnet mapper. So this data could be used in webhook calls.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments