Skip to content

Conversation

@G3root
Copy link
Contributor

@G3root G3root commented Sep 30, 2022

What does this PR do?

Fixes #514

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Existing unit tests

@ghost
Copy link

ghost commented Sep 30, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@socket-security
Copy link

socket-security bot commented Sep 30, 2022

Socket Security Report

👍 No new dependency issues detected in pull request

Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ✅ no new install scripts
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@deepakprabhakara
Copy link
Collaborator

Nice work @G3root, one example of a translation text would be nice. We'll add the rest incrementally

@devkiran
Copy link
Contributor

devkiran commented Oct 3, 2022

Tested the changes locally, and translation is working.

@deepakprabhakara
Copy link
Collaborator

@G3root Could you please resolve the conflicts and we can get this PR merged. Thank you, looks great.

@G3root
Copy link
Contributor Author

G3root commented Oct 5, 2022

@G3root Could you please resolve the conflicts and we can get this PR merged. Thank you, looks great.

resolved

@deepakprabhakara deepakprabhakara merged commit 05eeb7f into ory:main Oct 8, 2022
@deepakprabhakara
Copy link
Collaborator

Thanks @G3root

@G3root G3root deleted the add-i18n branch October 8, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n internationalization

3 participants