Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure OTEL collector endpoint #646

Closed
4 of 6 tasks
omerlh opened this issue Dec 12, 2022 · 4 comments
Closed
4 of 6 tasks

Allow to configure OTEL collector endpoint #646

omerlh opened this issue Dec 12, 2022 · 4 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.

Comments

@omerlh
Copy link

omerlh commented Dec 12, 2022

Preflight checklist

Describe your problem

Provide a way to configure the OTEL (for example, Jaeger) collector endpoint. Looking at the code, it seems that no configuration is passed so the library will use the default - which is localhost.

Describe your ideal solution

A config option, like Jaeger or Zipkin, to specify the host and port.

Workarounds or alternatives

Not that I am aware of.

Version

latest

Additional Context

No response

@omerlh omerlh added the feat New feature or request. label Dec 12, 2022
@bodymindarts
Copy link

Blocker for us too. Should be a small change as otlptracehttp package supports passing in an endpoint as an option https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp#Option.

@bodymindarts
Copy link

bodymindarts commented Mar 1, 2023

In latest release of oath keeper + kratos the following config worked:

      tracing:
        service_name: oath keeper
        provider: otel
        providers:
          otlp:
            server_url: <otel-endpoint>:4318
            insecure: true

Copy link

github-actions bot commented Mar 1, 2024

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Mar 1, 2024
@alnr
Copy link
Contributor

alnr commented Mar 28, 2024

This is fixed I believe, but beware #778

@alnr alnr closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

3 participants