From 2397575c0405fab3a9763f363178d7ac059dc5f2 Mon Sep 17 00:00:00 2001
From: Liv Dywan <liv.dywan@suse.com>
Date: Mon, 23 Sep 2024 16:58:14 +0200
Subject: [PATCH] Remove deprecated legacy job group view

The old view has been deprecated 5 years ago.

Related: https://progress.opensuse.org/issues/166310#note-14
---
 assets/javascripts/job_templates.js           |  6 --
 .../WebAPI/Controller/Admin/JobTemplate.pm    |  3 -
 .../webapi/admin/job_template/index.html.ep   | 56 -------------------
 3 files changed, 65 deletions(-)

diff --git a/assets/javascripts/job_templates.js b/assets/javascripts/job_templates.js
index 362a2f2b502..c611cd4902e 100644
--- a/assets/javascripts/job_templates.js
+++ b/assets/javascripts/job_templates.js
@@ -3,12 +3,6 @@ var job_group_id;
 var user_is_admin;
 var editor;
 
-function setupJobTemplates(url, id) {
-  job_templates_url = url;
-  job_group_id = id;
-  $.ajax(url + '?group_id=' + id).done(loadJobTemplates);
-}
-
 function loadJobTemplates(data) {
   var mediagroups = {};
   var groups = [];
diff --git a/lib/OpenQA/WebAPI/Controller/Admin/JobTemplate.pm b/lib/OpenQA/WebAPI/Controller/Admin/JobTemplate.pm
index 3e2ccdf6d86..242e73f3177 100644
--- a/lib/OpenQA/WebAPI/Controller/Admin/JobTemplate.pm
+++ b/lib/OpenQA/WebAPI/Controller/Admin/JobTemplate.pm
@@ -12,12 +12,9 @@ sub index {
     return $self->reply->not_found unless $group;
 
     my $yaml = $group->template;
-    my $force_yaml_editor
-      = defined $yaml || $schema->resultset('JobTemplates')->search({group_id => $group->id}, {rows => 1})->count == 0;
     $self->stash(
         group => $group,
         yaml_template => $yaml,
-        force_yaml_editor => $force_yaml_editor,
     );
 
     my @machines = $schema->resultset('Machines')->search(undef, {order_by => 'name'});
diff --git a/templates/webapi/admin/job_template/index.html.ep b/templates/webapi/admin/job_template/index.html.ep
index 9280263e119..f69d6615e61 100644
--- a/templates/webapi/admin/job_template/index.html.ep
+++ b/templates/webapi/admin/job_template/index.html.ep
@@ -6,41 +6,15 @@
 
 % title 'Job templates for ' . $group->name;
 
-% unless ($force_yaml_editor) {
-    <div class="alert alert-danger">
-        The old job group view is deprecated and will be removed from
-        future versions of openQA. Please save the job templates in YAML
-        format as soon as possible.
-    </div>
-% }
-
 % content_for 'ready_function' => begin
     user_is_admin = <%= is_admin_js %>;
-    % if ($force_yaml_editor) {
         toggleTemplateEditor();
-    % }
-    % else {
-        setupJobTemplates("<%= url_for('apiv1_job_templates') %>", <%= $group->id %>);
-    % }
     $('#expand-template').click(function() { submitTemplateEditor('expand'); });
     $('#preview-template').click(function() { submitTemplateEditor('preview'); });
     $('#save-template').click(function() { submitTemplateEditor('save'); });
 % end
 
         <form action="<%= url_for('admin_groups') %>" class="corner-buttons">
-            % if (!$force_yaml_editor) {
-            <button type="button" id="toggle-yaml-editor" class="btn btn-light" onclick="toggleTemplateEditor();">
-                <span>
-                    <i class="fa fa-edit"></i>
-                    % if (is_admin) {
-                        Edit YAML
-                    % }
-                    % else {
-                        Show YAML
-                    % }
-                </span>
-            </button>
-            % }
             <button type="button" id="toggle-group-properties" class="btn btn-light" onclick="toggleEdit();">
                 <span>
                     <i class="fa fa-edit"></i>
@@ -74,30 +48,6 @@
             <a href="http://open.qa/docs/#_using_job_templates_to_automate_jobs_creation" target="blank">the documentation</a>
             for more details.
         </p>
-        % if (!$force_yaml_editor) {
-            <div id="media">
-                <p id="loading"><i class="fa fa-spinner fa-spin"></i> Loading…</p>
-
-                <select id="machines-template" multiple="true" disabled data-placeholder="None" style="display: none">
-                    % for my $machine (@$machines) {
-                        <option value="<%= $machine->name %>"
-                                data-machine-id="<%= $machine->id %>" >
-                            %= $machine->name
-                        </option>
-                    % }
-                </select>
-
-                <select id="tests-template" disabled style="display: none">
-                    <option value="">Select…</option>
-                    % for my $test (@$tests) {
-                        <option value="<%= $test->name %>" data-test-id="<%= $test->id %>">
-                            %= $test->name
-                        </option>
-                    % }
-                </select>
-
-            </div>
-        % }
         <form action="#" id="editor-form" class="form-horizontal" style="display: none;"
               data-put-url="<%= url_for('apiv1_job_templates_schedules' => (id => $group->id)) %>" data-reference="<%= $yaml_template %>">
             <div class="row">
@@ -204,9 +154,3 @@ scenarios:
                 </div>
             </div>
         </form>
-
-        % if (!$force_yaml_editor && is_admin) {
-            <p>
-                <i class="fa fa-plus-square"></i> Please save as YAML to add new medium as part of this group
-            </p>
-        % }