Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/perlcriric fails in Leap 15.5 #48

Open
perlpunk opened this issue Feb 7, 2024 · 4 comments
Open

tools/perlcriric fails in Leap 15.5 #48

perlpunk opened this issue Feb 7, 2024 · 4 comments

Comments

@perlpunk
Copy link
Collaborator

perlpunk commented Feb 7, 2024

% tools/perlcritic .
lib/OpenQA/Test/PatchDeparse.pm source OK
lib/OpenQA/Test/TimeLimit.pm source OK
lib/perlcritic/Perl/Critic/Policy/ArgumentInUseStrictWarnings.pm source OK
lib/perlcritic/Perl/Critic/Policy/RedundantStrictWarning.pm source OK
lib/perlcritic/Perl/Critic/Policy/SpaceAfterSubroutineName.pm source OK
lib/perlcritic/Perl/Critic/Policy/HashKeyQuotes.pm source OK
tools/perlcritic source OK
tools/tidyall source OK
tools/update-deps source OK
xt/01-make-update-deps.t source OK
::warning file=local/bin/perltidy,line=1,col=1,title=Missing strict or warnings - severity 4::[Community::StrictWarnings] The strict and warnings pragmas are important to avoid common pitfalls and deprecated/experimental functionality. Make sure each script or module contains "use strict; use warnings;" or a module that does this for you
::warning file=local/bin/perltidy,line=1,col=1,title=Missing strict or warnings - severity 4::[Community::StrictWarnings] The strict and warnings pragmas are important to avoid common pitfalls and deprecated/experimental functionality. Make sure each script or module contains "use strict; use warnings;" or a module that does this for you
::warning file=local/bin/perltidy,line=6,col=1,title=Code before strictures are enabled - severity 5::[TestingAndDebugging::RequireUseStrict] See page 429 of PBP
::warning file=local/bin/perltidy,line=12,col=45,title=Useless interpolation of literal string - severity 3::[ValuesAndExpressions::ProhibitInterpolationOfLiterals] See page 51 of PBP
Fatal error while critiquing "local/lib/perl5/Perl/Tidy.pm": Can't call method "isa" without a package or object reference at /home/tina/develop/github/os-autoinst-common/tools/../lib/perlcritic/Perl/Critic/Policy/SpaceAfterSubroutineName.pm line 54.

Why is the workflow https://github.com/os-autoinst/os-autoinst-common/actions/runs/7814037291/job/21314430765#step:4:2 passing?

@perlpunk
Copy link
Collaborator Author

perlpunk commented Feb 7, 2024

I think because I had a newer perlcritic version installed in local/.
However, if this new perlcritic version breaks lib/perlcritic/Perl/Critic/Policy/SpaceAfterSubroutineName.pm then this should be fixed.

@okurz
Copy link
Member

okurz commented Feb 7, 2024

Could be. I could not reproduce the problem

@perlpunk
Copy link
Collaborator Author

perlpunk commented Feb 7, 2024

Ah no, I had Perl::Tidy installed in local, and perlcritic running on local/lib/perl5/Perl/Tidy.pm produced this problem.
This should not happen. SpaceAfterSubroutineName.pm needs to be fixed.

@josegomezr
Copy link
Contributor

#36 solves this issue and can critique Perl/Tidy.pm without issues :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants