Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed screen layout overlapping issue #238

Merged

Conversation

tuj
Copy link
Contributor

@tuj tuj commented Mar 27, 2024

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/280

Description

  • Fixed screen layout overlapping issue.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@tuj tuj requested a review from rimi-itk March 27, 2024 06:03
@tuj tuj self-assigned this Mar 27, 2024
@tuj tuj added the bug Something isn't working label Mar 27, 2024
@@ -113,7 +113,7 @@ function GridGenerationAndSelect({
</div>
</div>
</div>
<div className="col-md-12">
<div className="col-md-8">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you absolutely sure that this should be 8? Many other numbers exist, like 42 and 87, just to name a few.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big decision...
The doubt is strong...
...
I'm sticking with 8.

@tuj tuj merged commit 990a38d into os2display:develop Mar 27, 2024
3 of 4 checks passed
@tuj tuj deleted the feature/280-screen-layout-overlap branch March 27, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants