Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2314 save playlist and regions in screen manager #259

Merged

Conversation

sinejespersen
Copy link
Contributor

@sinejespersen sinejespersen commented Sep 26, 2024

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/2314

Description

Related to: os2display/display-api-service#213

  • Clean up screen-manager.jsx
  • Add saving of playlists/groups with screen (as opposed to after)
  • Change bootstrap column class from col-md-8 -> col-md-12 (see image below)
  • Update api.generated.ts to match related pr
  • Fix a small console errer to do with key in login.jsx
  • Add @rtk-incubator/rtk-query-codegen-openapi to package.json
  • Sort playlists based on weight in drag/drop component

Screenshot of the result

image

tuj
tuj previously approved these changes Sep 30, 2024
.loading-spinner {
margin-right: 1em;
}
.loading-spinner {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-02 at 20 03 11

@sinejespersen sinejespersen requested a review from tuj October 9, 2024 09:06
src/components/user/login.jsx Outdated Show resolved Hide resolved
tuj
tuj previously approved these changes Oct 21, 2024
@sinejespersen sinejespersen force-pushed the feature/2314-save-playlist-and-regions-in-screen-manager branch from ac165be to f10897b Compare October 23, 2024 09:39
@sinejespersen sinejespersen merged commit bf4f641 into develop Oct 23, 2024
4 checks passed
@sinejespersen sinejespersen deleted the feature/2314-save-playlist-and-regions-in-screen-manager branch October 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants