Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

Consistency Check ignoring connection error source #116

Open
thari opened this issue Nov 18, 2016 · 1 comment
Open

Consistency Check ignoring connection error source #116

thari opened this issue Nov 18, 2016 · 1 comment

Comments

@thari
Copy link

thari commented Nov 18, 2016

--Test case: Error originating from a connection, sank in device2, but not
--recognized by consistency check that it has an error source
--https://github.com/osate/ErrorModelV2/blob/develop/org.osate.aadl2.errormodel.analysis/src/org/osate/aadl2/errormodel/analysis/actions/ConsistencyAction.java
--line no: 354
--Error : Incoming propagation I1 not correctly handled

system implementation TestSystem.imp
	subcomponents
		dev1: device Device1.imp;
		dev2: device Device2.imp;
	connections
		conn1: port dev1.O1 -> dev2.I1;
	annex EMV2 {**
		use types ErrorLibrary; 	
		connection error
		-- Error source
			conn1_error: error source conn1{ValueError}; 
		end connection;
	**};
end TestSystem.imp;

device Device1
	features
		O1: out data port;
end Device1;

device implementation Device1.imp
end Device1.imp;

device Device2
	features
		I1: in data port;
	annex EMV2 {**
		use types ErrorLibrary;
		error propagations
		--error sink
			I1 : in propagation {ValueError};
		flows
			--error sink
			incoming_error_sink : error sink I1{ValueError}; 
		end propagations;
	**};
end Device2;

device implementation Device2.imp
end Device2.imp;

Reproduction Step:

  1. Load the provided model snippet into Osate2
  2. Instantiate TestSystem.imp
  3. Right click the generated instance -> AADL Analyses -> Fault Analyses -> Consistency Checks
  4. Problems listed: Incoming propagation I1 not correctly handled
@sprocter
Copy link
Contributor

sprocter commented Dec 2, 2016

As a workaround to this, you may want to consider binding to a bus -- then, the bus can be the error source, which is similar to the semantics of the connection error source.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants