Repair event initiators not type checked

[joeseibel]

Repair events and recover events both have a when clause which can refer to event initiators. In the grammar and meta-model, these are references to NamedElement objects and the scope provider adds all members of the classifier to the scope. Type checking is performed by the validator and ensures that the reference can only be to a ModeTransition, Port, or InternalFeature.

This validation is checked for RecoverEvent, but not RepairEvent. It looks like Peter wanted the validator to check both recover and repair, but only recover ended up getting validated.

Validation occurs in the method checkRecoverEventTriggerType(RecoverEvent) which is called by caseRecoverEvent(RecoverEvent) and caseRepairEvent(RecoverEvent). As you can see, both caseRecoverEvent and caseRepairEvent take a RecoverEvent as a parameter. This results in RecoverEvent being validated twice and RepairEvent not being evaluated.

The method caseRepairEvent(RecoverEvent) should be changed to take a RepairEvent as a parameter and checkRecoverEventTriggerType should be updated to perform type checking on both RecoverEvent and RepairEvent.