main: check if local storage is mounted when --local flag is used (HMS-3792)
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Mar 12, 2024
cgwalters
reviewed
Mar 12, 2024
cgwalters
reviewed
Mar 12, 2024
ochosi
changed the title
kingsleyzissou
commented
Mar 13, 2024
ochosi
changed the title
kingsleyzissou
force-pushed
the
local-follow-up
branch
from
410c36a
to
ac1eef7
Compare
A local container image from the host is being used.
Since we are using local storage by default, Wwe should fail early if it hasn't been mounted. Some undefined behaviour has been seen when local storage volume hasn't been mounted and the `--local` flag has been provided.
kingsleyzissou
force-pushed
the
local-follow-up
branch
from
ac1eef7
to
56ce13b
Compare
kingsleyzissou
changed the title
--local flag is used (HMS-3792)
|
Closing in favour of #293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #120 and addresses some of the comments on the PR.
The most notable change is switching to use local storage as the default. A helper function is introduced to check if the image is in the local store and, if not, copy it into the store.