Added check for missing marketplaceProductCodes in instance identity. #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslebodn
reviewed
Oct 3, 2024
| expected_billing_codes = ['bp-63a5400a'] | ||
| else: | ||
| pytest.skip( | ||
| 'Unable to decide billing codes as no "Hourly2" or "Access2" found in AMI name') |
There was a problem hiding this comment.
Could you add ami_name to the message?
|
|
||
| obtained_marketplace_product_codes = list(instance_data_aws_web['marketplaceProductCodes']) | ||
|
|
||
| print(f'marketplaceProductCodes = {obtained_billing_codes}') |
There was a problem hiding this comment.
copy& paste issue?
marketplaceProductCodes vs obtained_billing_code
| for code in billing_codes: | ||
| assert code in instance_data_aws_web['billingProducts'], \ | ||
| 'Expected billing code not found in instance document data' | ||
| assert len(obtained_marketplace_product_codes) > 1, 'List of marketplaceProductCodes is empty' |
There was a problem hiding this comment.
This will fail for pre-release testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.