Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use BigObject<type> information from json #267

Open
kalmarek opened this issue Apr 22, 2020 · 3 comments
Open

use BigObject<type> information from json #267

kalmarek opened this issue Apr 22, 2020 · 3 comments

Comments

@kalmarek
Copy link
Contributor

Maybe our faux constructors can actually create types:
e.g. Polytope{Rational}(...) could create BigObject{Polytope{Rational}}

this way we could leverage dispatch for auto-generated functions (and their docs).
Right now e.g. polytope.dim function is created three times (with the same signature, so we don't see warnings) and docs are overwritten, so we need to do hacks like this:

aggregate = Dict{String, Vector{Int}}()

@benlorenz
Copy link
Member

We would need to add the dependency tree as well? A function taking a Cone can also accept a Polytope.

@kalmarek
Copy link
Contributor Author

can we we see the hierarchy somehow in json?
these three definitions for dim would cover that without the necessity of duplicating the hierarchy, but maybe that will probably only work for methods....

@benlorenz
Copy link
Member

benlorenz commented May 13, 2020

#285 contains a new field linear_isa for the BigObjects:

      "name" : "VoronoiPolyhedron",
      "linear_isa" : [
        "polytope::Polytope",
        "polytope::Cone"
      ],

It will list all (generic) types that the current type inherits from (also indirect dependencies but I could change that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants