Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(release-please): release-please as a new option for release automation (WIP) #304

Closed
wants to merge 5 commits into from
Closed

feat(release-please): release-please as a new option for release automation (WIP) #304

wants to merge 5 commits into from

Conversation

Naman-Priyadarshi
Copy link
Contributor

@Naman-Priyadarshi Naman-Priyadarshi commented Jul 13, 2024 •
edited
Loading

Pull Request description

Created a new option release-please with options `semantic-release', 'release-please', and 'None'. The first one being the default choice. Currently a work in progress

Fixes #77

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@Naman-Priyadarshi
Copy link
Contributor Author

Hey @xmnlab, could you check the changes in the OSL and base profile? I am currently working on refactoring the existing semantic-release code so that all options can be used.

@xmnlab
Copy link
Member

xmnlab commented Jul 16, 2024

@Naman-Priyadarshi , I just added a comment in the base.yaml ... the osl.yaml looks good to me

@xmnlab
Copy link
Member

xmnlab commented Oct 7, 2024

Hi @Naman-Priyadarshi , thanks for working on that.
I am closing this PR, but feel free to reopen that if you have more updates.
all the best,

@xmnlab xmnlab closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add release-please an an option for release workflow
2 participants
@Naman-Priyadarshi @xmnlab