From ef552143b1dfc87b1697b98b7fdd5d2eac4cf4b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Minh=20Nguy=E1=BB=85n?= Date: Thu, 24 Feb 2022 02:52:47 -0800 Subject: [PATCH 1/3] Added route shields for the Philippines --- style/icons/shield40_ph_expressway_2.svg | 3 +++ style/icons/shield40_ph_national_2.svg | 3 +++ style/icons/shield40_ph_national_3.svg | 3 +++ style/js/shield_defs.js | 28 ++++++++++++++++++++++++ 4 files changed, 37 insertions(+) create mode 100644 style/icons/shield40_ph_expressway_2.svg create mode 100644 style/icons/shield40_ph_national_2.svg create mode 100644 style/icons/shield40_ph_national_3.svg diff --git a/style/icons/shield40_ph_expressway_2.svg b/style/icons/shield40_ph_expressway_2.svg new file mode 100644 index 000000000..df4e86520 --- /dev/null +++ b/style/icons/shield40_ph_expressway_2.svg @@ -0,0 +1,3 @@ + + + diff --git a/style/icons/shield40_ph_national_2.svg b/style/icons/shield40_ph_national_2.svg new file mode 100644 index 000000000..ee06bfa8b --- /dev/null +++ b/style/icons/shield40_ph_national_2.svg @@ -0,0 +1,3 @@ + + + diff --git a/style/icons/shield40_ph_national_3.svg b/style/icons/shield40_ph_national_3.svg new file mode 100644 index 000000000..1aa017fc7 --- /dev/null +++ b/style/icons/shield40_ph_national_3.svg @@ -0,0 +1,3 @@ + + + diff --git a/style/js/shield_defs.js b/style/js/shield_defs.js index 6b51ffde6..68da655f0 100644 --- a/style/js/shield_defs.js +++ b/style/js/shield_defs.js @@ -798,6 +798,34 @@ export function loadShields(shieldImages) { }, }; + shields["PH:N"] = + shields["PH:N:primary"] = + shields["PH:N:secondary"] = + shields["ph:nhn"] = + { + backgroundImage: [ + shieldImages.shield40_ph_national_2, + shieldImages.shield40_ph_national_3, + ], + textColor: "black", + padding: { + left: 2, + right: 2, + top: 2, + bottom: 6, + }, + }; + shields["PH:E"] = { + backgroundImage: shieldImages.shield40_ph_expressway_2, + textColor: "black", + padding: { + left: 2, + right: 2, + top: 2, + bottom: 6, + }, + }; + shields["TW:freeway"] = { backgroundImage: shieldImages.shield40_tw_freeway, textLayoutConstraint: ShieldText.ellipseTextConstraint, From 80e619aadb1283b49f49bcb6feb061917ca59905 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Minh=20Nguy=E1=BB=85n?= Date: Fri, 25 Feb 2022 11:33:50 -0800 Subject: [PATCH 2/3] Dropped network=ph:nhn This generic value requires the nonstandard, unsupported key nhn:class for disambiguating expressways, primary routes, secondary routes, and tertiary routes. --- style/js/shield_defs.js | 1 - 1 file changed, 1 deletion(-) diff --git a/style/js/shield_defs.js b/style/js/shield_defs.js index 68da655f0..556c9c99c 100644 --- a/style/js/shield_defs.js +++ b/style/js/shield_defs.js @@ -801,7 +801,6 @@ export function loadShields(shieldImages) { shields["PH:N"] = shields["PH:N:primary"] = shields["PH:N:secondary"] = - shields["ph:nhn"] = { backgroundImage: [ shieldImages.shield40_ph_national_2, From 8257799a314ce6ab7a6d00784c939654ee3c9c55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Minh=20Nguy=E1=BB=85n?= Date: Wed, 9 Mar 2022 17:22:30 -0800 Subject: [PATCH 3/3] Dropped PH:N:primary, PH:N:secondary --- style/js/shield_defs.js | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/style/js/shield_defs.js b/style/js/shield_defs.js index 556c9c99c..1c463c91c 100644 --- a/style/js/shield_defs.js +++ b/style/js/shield_defs.js @@ -798,22 +798,19 @@ export function loadShields(shieldImages) { }, }; - shields["PH:N"] = - shields["PH:N:primary"] = - shields["PH:N:secondary"] = - { - backgroundImage: [ - shieldImages.shield40_ph_national_2, - shieldImages.shield40_ph_national_3, - ], - textColor: "black", - padding: { - left: 2, - right: 2, - top: 2, - bottom: 6, - }, - }; + shields["PH:N"] = { + backgroundImage: [ + shieldImages.shield40_ph_national_2, + shieldImages.shield40_ph_national_3, + ], + textColor: "black", + padding: { + left: 2, + right: 2, + top: 2, + bottom: 6, + }, + }; shields["PH:E"] = { backgroundImage: shieldImages.shield40_ph_expressway_2, textColor: "black",