Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iD incorrectly offers to upgrade London Underground stations to London Overground #10167

Open
peternewman opened this issue Nov 24, 2024 · 3 comments
Labels

Comments

@peternewman
Copy link
Collaborator

https://nsi.guide/index.html?t=transit&k=public_transport&v=station_subway&tt=london%20under#londonunderground-05dd5a
to
https://nsi.guide/index.html?t=transit&k=railway&v=station&tt=london%20overg#londonoverground-4a7f23

For at least Oxford Circus:
https://www.openstreetmap.org/node/5614077964

Although not Great Portland Street (presumably due to the lack of operator):
https://www.openstreetmap.org/node/6414039764

I assume this is because an underground station:

public_transport=station
railway=station
station=subway
subway=yes

Is essentially a subset of a railway station:

public_transport=station
railway=station
train=yes

I'm not sure how to fix it short of tagging train=no it turns out you can't actually solve it with not:operator:wikidata as it also matches the Elizabeth Line ( https://nsi.guide/index.html?t=transit&k=railway&v=station&tt=eliz#elizabethline-abdde3 ) and it doesn't support semicolon or comma listing of multiple values.

@Snowysauce
Copy link
Collaborator

This is probably related to the iD-specific behavior described at #9996 (comment), so I'm not sure if anything can be done about this on NSI's end.

@UKChris-osm
Copy link
Collaborator

Great Portland Street doesn't include a network:wikidata at the moment, so I expect that's why no suggestions are taking place. Adding the underground network:wikidata causes the same suggestions to override with the Overground and Elizabeth Line.

Clicking not just seems to rotate between Elizabeth and Overground continuously.

@bhousel
Copy link
Member

bhousel commented Nov 27, 2024

Yeah this does seem to be an issue only with iD. If the station already has network and operator values, I don't know why it would want to switch London Underground and London Overground.

I tested this station in Rapid and I don't get the issue:
https://rapideditor.org/canary#map=20.24/51.51544/-0.14196&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&id=n5614077964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants