Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure country code is added to phone number #94

Open
tastrax opened this issue Aug 2, 2021 · 2 comments
Open

Ensure country code is added to phone number #94

tastrax opened this issue Aug 2, 2021 · 2 comments

Comments

@tastrax
Copy link

tastrax commented Aug 2, 2021

It would be useful to validate if the phone number has the country code before submitting to OSM. There is a worldwide push to get numbers corrected. https://maproulette.org/browse/challenges?query=phone

@le-jun
Copy link
Contributor

le-jun commented Aug 7, 2021

As long as the number isn’t added as it is into OSM but only creates a note I classify this issue as minor. On the other hand while the "phoneplaceholder" do a pretty good job at hinting the country code I agree that a validation may be necessary. A simple way to do that would be to verify if a + sign is added in the form as there’s a low chance of misstyping it.

@iandees
Copy link
Member

iandees commented Aug 8, 2021

I could see us using something like libphonenumber.js to format the number properly as it goes to OSM as a note. That'd be a useful pull request to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants