Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make memDB iterators not use channels #19

Closed
daniel-farina opened this issue Nov 19, 2021 · 0 comments
Closed

Make memDB iterators not use channels #19

daniel-farina opened this issue Nov 19, 2021 · 0 comments

Comments

@daniel-farina
Copy link
Contributor

Using channels in the memdb iterator is very high overhead, that doesn't make sense imo: https://github.com/tendermint/tm-db/blob/release/0.6.x/memdb_iterator.go#L40-L85

This should instead all be put into a struct, which would make this performance sensitive code way faster.

tendermint/tm-db#188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants