Merge pull request #80 from osmosis-labs/remove-tx-id

Remove unneeded tx_id from Stake / Unstake Ack packets
osmosis-labs · Jun 28, 2023 · df58e1a · df58e1a
2 parents caf0552 + a85c6f6
commit df58e1a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/contracts/consumer/converter/src/ibc.rs b/contracts/consumer/converter/src/ibc.rs
@@ -152,10 +152,10 @@ pub fn ibc_packet_receive(
         ProviderPacket::Stake {
             validator,
             stake,
-            tx_id,
+            tx_id: _,
         } => {
             let response = contract.stake(deps, validator, stake)?;
-            let ack = ack_success(&StakeAck { tx_id })?;
+            let ack = ack_success(&StakeAck {})?;
             IbcReceiveResponse::new()
                 .set_ack(ack)
                 .add_submessages(response.messages)
@@ -165,10 +165,10 @@ pub fn ibc_packet_receive(
         ProviderPacket::Unstake {
             validator,
             unstake,
-            tx_id,
+            tx_id: _,
         } => {
             let response = contract.unstake(deps, validator, unstake)?;
-            let ack = ack_success(&UnstakeAck { tx_id })?;
+            let ack = ack_success(&UnstakeAck {})?;
             IbcReceiveResponse::new()
                 .set_ack(ack)
                 .add_submessages(response.messages)

diff --git a/packages/apis/src/ibc/packet.rs b/packages/apis/src/ibc/packet.rs
@@ -32,17 +32,11 @@ pub enum ProviderPacket {
 
 /// Ack sent for ProviderPacket::Stake
 #[cw_serde]
-pub struct StakeAck {
-    /// Return the value from the original packet
-    pub tx_id: u64,
-}
+pub struct StakeAck {}
 
 /// Ack sent for ProviderPacket::Unstake
 #[cw_serde]
-pub struct UnstakeAck {
-    /// Return the value from the original packet
-    pub tx_id: u64,
-}
+pub struct UnstakeAck {}
 
 /// These are messages sent from consumer -> provider
 /// ibc_packet_receive in external-staking must handle them all.