Allow instantiating vault with existing local staking contract #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeHartnell
commented
May 29, 2024
Comment on lines
+18
to
+33
| /// Information about the local staking contract used during vault instantiation | ||
| /// We use untagged so older clients that just used JSON encoded StakingInitInfo | ||
| /// will continue to work with no changes. | ||
| #[cw_serde] | ||
| pub enum LocalStakingInfo { | ||
| #[serde(untagged)] | ||
| Existing(ExistingContract), | ||
| #[serde(untagged)] | ||
| New(StakingInitInfo), | ||
| } | ||
|
|
||
| #[cw_serde] | ||
| pub struct ExistingContract { | ||
| /// Address of the local staking contract | ||
| pub existing: String, | ||
| } |
There was a problem hiding this comment.
It's amazing we have such super powers now. Thanks @ethanfrey for pointing this out to me.
ethanfrey
approved these changes
May 30, 2024
ethanfrey
deleted the
instantiate-vault-with-existing-local-staking-contract
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was playing around with allowing a DAO to have its own mesh vault and realized we needed to be able to instantiate the vault from the local staking contract. Thanks to @ethanfrey for feedback and figuring out how we can clean support the existing interface used in the Mesh Security UI.