Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can i use 1 Tag instead of 3? #14

Open
UsamaArshad16 opened this issue Dec 21, 2022 · 2 comments
Open

Can i use 1 Tag instead of 3? #14

UsamaArshad16 opened this issue Dec 21, 2022 · 2 comments

Comments

@UsamaArshad16
Copy link

Can i use 1 Tag instead of 3?

@LKSeng
Copy link

LKSeng commented Dec 23, 2022

If you want to use 1 Tag you'll need to modify the code. You can start by looking at the do_predock() function, and change the line centre_tf = self.get_centre_of_side_markers() to something that uses only 1 marker.

Preempting the question of why 3 markers are used instead of 1, I am not the author of the code, but I have hypothesised some reasons why the 3 Tags are used here.

@youliangtan
Copy link
Contributor

Yes the above comments are right.
When looking at the state machine diagram on the readme, the sides markers are used during predock, and steerdock states. You can try to edit the way both do_single_side_marker_rotate() and get_centre_of_side_markers() are currently implemented. PR is always welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants