-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scanner freezes when using ClearlyDefined as a scan storage provider #4540
Comments
We're also facing timeout issues with ClearlyDefined recently. My hope is that working on #3905 will address this. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
If I configure to read and write the scan result only on postgres it seems to stop due to a timeout:
Would it help to configure the timeout of ScanCode |
Hmm, I don't see ScanCode running into a timeout in the logs you posted (you should see a message like "Timeout ... while scanning file ..." then). As Netty is a rather big package IIRC, the scan could simply take long. A ScanCode scan can easily take several hours depending on the code size. PS: The timeout is per file, not per total scan duration. |
It does not even continue after more than one hour from this package only on postgres. But also with clearlyDefined it stops after some minutes scanning - not at the same package when I want to reproduce it. It does not continue even after several hours. I have never seen the timeout message in the logs so a longer timeout probably won't be a solution.
|
The scan passed |
I'm also facing this freeze issue when using clearlyDefined as storageReader.
ORT is in Any news on this? |
I guess no one is currently working on this because AFAIK ClearlyDefined uses a very old version of ScanCode by now, and thus it's quite unattractive to use ClearlyDefined as a scan storage reader currently... |
I accidentally came across this issue that I fixed, which likely also fixes this issue. Can anyone confirm? |
I would like to test this. Any particular projects that i can use as test cases ? Apart from the scanning not freezing or anything like that, how do i know that this works ? |
I just ran the scanner (main/73af92a4b86cb5e01c0b867e6eb64115ed692bf0) of ort with a https://github.com/tornadoweb/tornado/tree/master with no issues running the scanner. |
Just curios, do you perform any e2e tests of clearlydefined in a pipline or such ? |
No, currently not. |
That's good news. We should probably wait for other affected users to confirm the fix before closing this issue. |
I'll give it a try within the next days. With this configuration:
|
In our case there no timeout anymore with this configuration using the recent docker image of ORT:
|
Thanks for these confirmations, I'm closing this then. |
Hmm. I'm on commit main/ddfbf6289b4aef2b5acaf29dee6dd0718b27b52a and running the scanner locally (after Config is
So |
As mentioned in issue #5116 I also have the issue on latest dev. Commit ID is Caveat: it actually works on some projects (e.g. Eclipse JGit) but freezes on others (e.g. Eclipse Tycho). |
I tested with https://github.com/tornadoweb/tornado (python project) and it worked fine. |
Confirm freeze after a few minutes with latest dev and clearlyDefined |
Confirm freeze on a dotnetcore project:
|
For anyone who's still affected by this, can you please share your ORT analyzer result for a public (and as small as possible) project where you can reproduce the scanner freeze? |
I still have the freeze for the following package:
|
Just using that single artifact in |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Can anyone still reproduce the hanging with today's version of ORT? |
Now the freeze does not occur anymore for gradle packages. I used 32 GB and 32 CPUs because this also solved the Freeze of the ORT scan without ClearlyDefined as Read Only storage. |
Thanks for confirming. With the recent fixes for ORT's calls to the ClearlyDefined API (esp. for packages without namespaces) I indeed believe this to be fixed. If anyone still sees this, we can reopen the issue. |
I can confirm that the scanner does not freeze anymore, if ClearlyDefined is defined as storageReader (together with artifactoryStorage).
... Thank you for fixing it!!! smiley |
When i run the scanner using clearlydefined with a file based storage, the scanner seem to hang.
I don't know if its a problem using the clearlydefined api or if my configuration file is incorrect ?
Is there any flag to see more information from the scanner, like debug messages ?
The process doesn't seem to do much
The text was updated successfully, but these errors were encountered: