Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brainyquote.py: get_quotes returns wrong quotes #18

Open
prajwal72 opened this issue May 16, 2019 · 3 comments · May be fixed by #37
Open

brainyquote.py: get_quotes returns wrong quotes #18

prajwal72 opened this issue May 16, 2019 · 3 comments · May be fixed by #37
Labels
good first issue Good for newcomers Hacktoberfest go to https://hacktoberfest.digitalocean.com/ for more details

Comments

@prajwal72
Copy link
Member

brainyquote.py: get_quotes returns first x quotes by the author instead of the quotes belonging to the said category
@Rits1272
Copy link
Member

Got the bug will solve it till tommorow.

@yugaljain1999
Copy link

There is some error in get_quote function too, as there we choose randomly quotes sometimes it returns
(author_name,author_name) instead of (quote,author_name)...

@parammittal16 parammittal16 linked a pull request Jul 27, 2019 that will close this issue
Open
@parammittal16
Copy link
Contributor

Fixed it! plz review the PR.

@svp19 svp19 assigned sunn-e and unassigned sunn-e Jul 28, 2019
@sunn-e sunn-e added Hacktoberfest go to https://hacktoberfest.digitalocean.com/ for more details good first issue Good for newcomers labels Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest go to https://hacktoberfest.digitalocean.com/ for more details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong returning quotes parammittal16/pyquotes
5 participants
@sunn-e @parammittal16 @prajwal72 @yugaljain1999 @Rits1272