Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package download flow #770

Open
maxfisher-g opened this issue Jun 19, 2023 · 0 comments
Open

Improve package download flow #770

maxfisher-g opened this issue Jun 19, 2023 · 0 comments
Labels
enhancement New feature or request needs discussion

Comments

@maxfisher-g
Copy link
Contributor

maxfisher-g commented Jun 19, 2023

Since #739 has been merged, we now have the ability to redownload and save the package archive (**) after analysis.

It would be ideal if the downloaded/saved archive is the same one that's used for analysis

Some possible ways to achieve this:

  1. Downloading the archive first in the worker container, then copying it into the static and dynamic sandboxes. These then do analysis as if on a local package.
  2. Have the static analysis sandbox double as the 'package downloader' container, then copy the downloaded files back to the host and into the dynamic analysis container, as well as uploading them to the bucket
  3. Have a separate 'downloader' container whose sole job is to download everything, and pass it to the other containers like in option 1.

** One caveat with all this is that Packagist packages hosted on GitLab don't offer direct package archive download URLs. We will need to figure out how to support this case (or possibly fall back to legacy behaviour).

@maxfisher-g maxfisher-g added enhancement New feature or request needs discussion labels Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs discussion
Projects
None yet
Development

No branches or pull requests

1 participant