Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to marshal a package should not result in hard failure during publishing #101

Open
Qinusty opened this issue May 4, 2021 · 2 comments

Comments

@Qinusty
Copy link
Contributor

Qinusty commented May 4, 2021

Failing to marshal a single package currently blocks the publishing of all subsequent packages, this is undesirable.

https://github.com/ossf/package-feeds/blob/ce53f3ea/cmd/scheduled-feed/main.go#L45-L50 is the relevant code chunk.

@tom--pollard
Copy link
Contributor

Seems sensible that this shouldn't lead to a complete loss of the subsequent package data. This might be somewhere to add another event, and simply continue.

@tom--pollard
Copy link
Contributor

Now that #123 has merged I'll look to update publishPackages() to handle errors on a per package basis, using errPub to align with poll()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants