Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Parser Ignorant of Context (quoted descipritons & compound words) #705

Closed
AlexWeinstein92 opened this issue Dec 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@AlexWeinstein92
Copy link
Collaborator

Symptom

In the screenshot below, the plugin is using TopLevelParser.parseToTokens" on the opened file's docString`.
Issues:

  1. The keywords which occur between quotes as descriptions (ie for event Restaurant.Payment.Paid) are still recognized as tokens despite the plugin's awareness of QuotedStringTKNs
  2. Compound words which include keywords or readability words are partially highlighted
Screenshot 2024-12-13 at 11 29 29 AM

Expected Behavior

  1. If quoted descriptions for events are still relevant to RIDDL, they should be recognized either as QuotedStringTKN or some other Token type by the parser
  2. Compound words which include words in the RIDDL lexicon should be ignored by the parser

The screenshot of the plugin uses riddl 0.56.0

@AlexWeinstein92 AlexWeinstein92 added the bug Something isn't working label Dec 13, 2024
@reid-spencer reid-spencer self-assigned this Dec 13, 2024
@AlexWeinstein92
Copy link
Collaborator Author

Markdown example requested by Reid:
Screenshot 2024-12-13 at 12 01 08 PM

@reid-spencer
Copy link
Contributor

The functionality of the token parser has changed significantly since last week. It should be all working by now.
Please try the plugin coloring again with the new version (HEAD of main), post an image of your results here. Once that is complete I will roll a new release so you can complete your plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants