Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Add an API to serialize Transport #497

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

cgwalters
Copy link
Member

This will fix the need demonstrated by
https://github.com/containers/bootc/pull/106/files#diff-c163debeb7fdf9b238e5c589e0000c80684ca9a09abd408242df4bad489626a6R38

We made a historical mistake here in having our Display include the :...but it's hard to deal with because inherently the format is messy because of the :// in docker://.

This will fix the need demonstrated by
https://github.com/containers/bootc/pull/106/files#diff-c163debeb7fdf9b238e5c589e0000c80684ca9a09abd408242df4bad489626a6R38

We made a historical mistake here in having our `Display` include
the `:`...but it's hard to deal with because inherently the format
is messy because of the `://` in `docker://`.
@jmarrero jmarrero enabled auto-merge July 6, 2023 13:23
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@jmarrero jmarrero merged commit e7e5d73 into ostreedev:main Jul 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants