Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair: Rework to be more introspectable #505

Merged
merged 1 commit into from
Jul 21, 2023

Commits on Jul 21, 2023

  1. repair: Rework to be more introspectable

    I plan to "productize" this repair code a bit more in OpenShift at
    least, and I think other admins may want to do similar outside
    of that too.
    
    In order to make that more reliable:
    
    - Better split the "fsck/--dry-run" path from "repair" i.e mutation
    - Introduce a `--write-result-to` argument that outputs
      JSON.  This allows us to better distinguish the tristate of
      "OK" from "corruption detected" to "tool failed for some other reason"
    
    Further:
    
    - Drop the check for derived commits, let's just *always* check
      the inodes because it's not very expensive in the end and
      it's just really useful to do.
    - Add checks for whether the booted deployment is potentially
      affected, as this is important information; we'll need to redeploy
      and reboot if so
    cgwalters committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    389a618 View commit details
    Browse the repository at this point in the history