lib: Dispatch to monomorphic function #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was looking at `cargo bloat` and this showed up near the top twice. It's a large function and only the option parsing needs to be generic.
|
@jmarrero We were talking about binary size of rpm-ostree, this is just one tiny dent in that. |
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Aug 16, 2023
This mirrors ostreedev/ostree-rs-ext#515 From looking at cargo bloat.
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Aug 16, 2023
This mirrors ostreedev/ostree-rs-ext#515 From looking at cargo bloat. Signed-off-by: Colin Walters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at
cargo bloatand this showed up near the top twice. It's a large function and only the option parsing needs to be generic.