Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/unencapsulate: Add proxy options #519

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

cgwalters
Copy link
Member

We need to support all the proxy options so that custom authentication files can be supported, etc.

Closes: ostreedev/ostree#3015

@cgwalters
Copy link
Member Author

    Compiling containers-image-proxy v0.5.3
error[E0716]: temporary value dropped while borrowed
   --> /github/home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/containers-image-proxy-0.5.3/src/imageproxy.rs:317:22
    |
317 |                 &mut [iov],
    |                      ^^^^^ creates a temporary value which is freed while still in use
...
320 |             )?;
    |               - temporary value is freed at the end of this statement
321 |             // SAFETY: We provided a buffer
322 |             let iov = r.iovs().next().unwrap();
    |                       -------- borrow later used here
    |
help: consider using a `let` binding to create a longer lived value
    |
315 ~             let binding = [iov];
316 ~             let r = nixsocket::recvmsg::<()>(
317 |                 sockfd.as_raw_fd(),
318 ~                 &mut binding,
    |

For more information about this error, try `rustc --explain E0716`.
error: could not compile `containers-image-proxy` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

Er...this just suddenly popped up; the relevant code here hasn't changed in a while. Presumably this is something with a new Rust toolchain since 1.72 just came out, but I'm not immediately reproducing it with that version here. In fact, even if I try to pull the current fcos buildroot container, it doesn't reproduce...weird.

@cgwalters
Copy link
Member Author

[time passes]
Ah hah, it's nix-rust/nix#2083

We need to support all the proxy options so that custom
authentication files can be supported, etc.

Closes: ostreedev/ostree#3015
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmarrero jmarrero merged commit b22f6a0 into ostreedev:main Aug 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication not working with ostree container unencapsulate
2 participants