Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/encapsulate: Add --authfile #523

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

cgwalters
Copy link
Member

Ideally we'd pass through all of the proxy options here, but doing that sanely really requires being able to do pushes through containers-image-proxy-rs, which is a quite nontrivial amount of work.

For now, let's pass through --authfile which is the main thing people want. Anything else can be worked around by encapsulating to oci and then doing a skopeo copy from there.

cc ostreedev/ostree#3015

Ideally we'd pass through all of the proxy options here, but
doing that sanely really requires being able to do *pushes*
through containers-image-proxy-rs, which is a quite nontrivial
amount of work.

For now, let's pass through `--authfile` which is the main thing
people want.  Anything else can be worked around by encapsulating
to `oci` and then doing a `skopeo copy` from there.

cc ostreedev/ostree#3015
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit 4c8bde9 into ostreedev:main Aug 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants