tar: Hold open input stream as long as possible #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we're hitting this in coreos/rpm-ostree#4567 but it'd be useful to have a trace message in case.
I'm hoping this will help us debug coreos/rpm-ostree#4567 ``` [2023-08-30T15:00:16.554Z] Aug 30 15:00:15 qemu0 kola-runext-container-image[1957]: error: Importing: Parsing layer blob sha256:00623c39da63781bdd3fb00fedb36f8b9ec95e42cdb4d389f692457f24c67144: Failed to invoke skopeo proxy method FinishPipe: remote error: write |1: broken pipe ``` I haven't been able to reproduce it outside of CI yet, but we had a prior ugly hack for this in ostreedev@a27dac8 As the comments say - the goal is to hold open the input stream as long as feasibly possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container: Add a trace log for when we discard "broken pipe" error
I don't think we're hitting this in coreos/rpm-ostree#4567
but it'd be useful to have a trace message in case.
tar: Hold open input stream as long as possible
I'm hoping this will help us debug coreos/rpm-ostree#4567
I haven't been able to reproduce it outside of CI yet, but we had
a prior ugly hack for this in
a27dac8
As the comments say - the goal is to hold open the input stream
as long as feasibly possible.