Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tar: Hold open input stream as long as possible #527

Merged
merged 2 commits into from
Aug 31, 2023
Merged

tar: Hold open input stream as long as possible #527

merged 2 commits into from
Aug 31, 2023

Commits on Aug 31, 2023

  1. container: Add a trace log for when we discard "broken pipe" error 

    I don't think we're hitting this in coreos/rpm-ostree#4567
but it'd be useful to have a trace message in case.
    @cgwalters
    cgwalters committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    e39b727 View commit details
    Browse the repository at this point in the history

  2. tar: Hold open input stream as long as possible 

    I'm hoping this will help us debug coreos/rpm-ostree#4567
```
[2023-08-30T15:00:16.554Z] Aug 30 15:00:15 qemu0 kola-runext-container-image[1957]: error: Importing: Parsing layer blob sha256:00623c39da63781bdd3fb00fedb36f8b9ec95e42cdb4d389f692457f24c67144: Failed to invoke skopeo proxy method FinishPipe: remote error: write |1: broken pipe
```

I haven't been able to reproduce it outside of CI yet, but we had
a prior ugly hack for this in
ostreedev@a27dac8

As the comments say - the goal is to hold open the input stream
as long as feasibly possible.
    @cgwalters
    cgwalters committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    13455cc View commit details
    Browse the repository at this point in the history