Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two minor patches #538

Merged
merged 2 commits into from
Sep 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ fn handle_serialize_to_file<T: serde::Serialize>(path: Option<&Utf8Path>, obj: T
}

/// Parse the provided arguments and execute.
/// Calls [`structopt::clap::Error::exit`] on failure, printing the error message and aborting the program.
/// Calls [`clap::Error::exit`] on failure, printing the error message and aborting the program.
pub async fn run_from_iter<I>(args: I) -> Result<()>
where
I: IntoIterator,
Expand Down
1 change: 1 addition & 0 deletions lib/src/container/encapsulate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ use tracing::instrument;
/// The label which may be used in addition to the standard OCI label.
pub const LEGACY_VERSION_LABEL: &str = "version";

// semver-break: Delete this and only support v1
/// Type of container image generated
#[derive(Debug, Copy, Clone, PartialEq, Eq)]
pub(crate) enum ExportLayout {
Expand Down
2 changes: 2 additions & 0 deletions lib/src/container/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1012,6 +1012,7 @@ pub fn query_image_commit(repo: &ostree::Repo, commit: &str) -> Result<Box<Layer
///
/// This is a thin wrapper for [`query_image_ref`] and should
/// be considered deprecated.
// semver-break: Delete this and rename query_image_ref -> query_image
pub fn query_image(
repo: &ostree::Repo,
imgref: &OstreeImageReference,
Expand All @@ -1030,6 +1031,7 @@ fn manifest_for_image(repo: &ostree::Repo, imgref: &ImageReference) -> Result<Im
/// Copy a downloaded image from one repository to another.
#[context("Copying image")]
#[deprecated = "Use copy_as instead"]
// semver-break: Delete this and rename copy_as -> copy
pub async fn copy(
src_repo: &ostree::Repo,
dest_repo: &ostree::Repo,
Expand Down
Loading