Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Add support for the dir transport #544

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

lukewarmtemp
Copy link
Contributor

This patch allows container image deployment stored in a local directory in addition to the supported remote OCI registry, OCI archive tarball, and local container storage. For example, the following command is now supported:

sudo ostree container image deploy --imgref ostree-unverified-image:dir:/var/home/core/fcos --sysroot /var/home/core/sysroot --stateroot fedora-coreos

The reason for making this change relates to the effort to create an FCOS qemu image from a container image input using OSBuild. OSBuild stores container image sources in a local directory in order to solve another bug and, thus, should not be changed. Therefore, to allow OSBuild to deploy from a container image, this patch is needed.

@cgwalters
Copy link
Member

Minor style note; we tend to use "Linux kernel style" git commits here, which use a "topic
prefix". Also the subject should be imperative.

Something like:

container: Add support for the dir transport

Procedurally otherwise, I think this makes sense, with the caveat that

   dir:path
    An  existing local directory path storing the manifest, layer tarballs and signatures as individual files. This is a non-standardized format, primarily useful for debugging or non‐
  invasive container inspection.
  • Please add some basic unit tests for parsing the transport
  • It'd also be nice to add an integration test

@cgwalters cgwalters added the needs-rework/failing-ci Legitimate CI failure label Sep 25, 2023
@lukewarmtemp lukewarmtemp force-pushed the accept-dir-container-deploy branch 2 times, most recently from ed4baf6 to a9d7376 Compare September 25, 2023 15:50
This patch allows container image deployment stored in a local directory in addition to the supported remote OCI registry, OCI archive tarball, and local container storage. For example, the following command is now supported:

sudo ostree container image deploy --imgref ostree-unverified-image:dir:/var/home/core/fcos --sysroot /var/home/core/sysroot --stateroot fedora-coreos

The reason for making this change relates to the effort to create an FCOS qemu image from a container image input using OSBuild. OSBuild stores container image sources in a local directory in order to solve another bug and, thus, should not be changed. Therefore, to allow OSBuild to deploy from a container image, this patch is needed.
@cgwalters cgwalters merged commit 88b5fc7 into ostreedev:main Sep 25, 2023
8 checks passed
@cgwalters cgwalters removed the needs-rework/failing-ci Legitimate CI failure label Sep 25, 2023
@lukewarmtemp lukewarmtemp changed the title Allows container deployment from local directory container: Add support for the dir transport Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants