forked from realm/SwiftLint
-
Notifications
You must be signed in to change notification settings - Fork 0
/
EmptyCountRule.swift
46 lines (41 loc) · 1.46 KB
/
EmptyCountRule.swift
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
//
// EmptyCountRule.swift
// SwiftLint
//
// Created by JP Simard on 11/17/15.
// Copyright © 2015 Realm. All rights reserved.
//
import SourceKittenFramework
public struct EmptyCountRule: ConfigurationProviderRule, OptInRule {
public var configuration = SeverityConfiguration(.error)
public init() {}
public static let description = RuleDescription(
identifier: "empty_count",
name: "Empty Count",
description: "Prefer checking `isEmpty` over comparing `count` to zero.",
kind: .performance,
nonTriggeringExamples: [
"var count = 0\n",
"[Int]().isEmpty\n",
"[Int]().count > 1\n",
"[Int]().count == 1\n",
"discount == 0\n",
"order.discount == 0\n"
],
triggeringExamples: [
"[Int]().↓count == 0\n",
"[Int]().↓count > 0\n",
"[Int]().↓count != 0\n",
"↓count == 0\n"
]
)
public func validate(file: File) -> [StyleViolation] {
let pattern = "\\bcount\\s*(==|!=|<|<=|>|>=)\\s*0"
let excludingKinds = SyntaxKind.commentAndStringKinds()
return file.match(pattern: pattern, excludingSyntaxKinds: excludingKinds).map {
StyleViolation(ruleDescription: type(of: self).description,
severity: configuration.severity,
location: Location(file: file, characterOffset: $0.location))
}
}
}