forked from realm/SwiftLint
-
Notifications
You must be signed in to change notification settings - Fork 0
/
FirstWhereRule.swift
95 lines (81 loc) · 3.74 KB
/
FirstWhereRule.swift
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
//
// FirstWhereRule.swift
// SwiftLint
//
// Created by Marcelo Fabri on 12/20/16.
// Copyright © 2016 Realm. All rights reserved.
//
import Foundation
import SourceKittenFramework
public struct FirstWhereRule: OptInRule, ConfigurationProviderRule {
public var configuration = SeverityConfiguration(.warning)
public init() {}
public static let description = RuleDescription(
identifier: "first_where",
name: "First Where",
description: "Prefer using `.first(where:)` over `.filter { }.first` in collections.",
kind: .performance,
nonTriggeringExamples: [
"kinds.filter(excludingKinds.contains).isEmpty && kinds.first == .identifier\n",
"myList.first(where: { $0 % 2 == 0 })\n",
"match(pattern: pattern).filter { $0.first == .identifier }\n"
],
triggeringExamples: [
"↓myList.filter { $0 % 2 == 0 }.first\n",
"↓myList.filter({ $0 % 2 == 0 }).first\n",
"↓myList.map { $0 + 1 }.filter({ $0 % 2 == 0 }).first\n",
"↓myList.map { $0 + 1 }.filter({ $0 % 2 == 0 }).first?.something()\n",
"↓myList.filter(someFunction).first\n",
"↓myList.filter({ $0 % 2 == 0 })\n.first\n"
]
)
public func validate(file: File) -> [StyleViolation] {
let pattern = "[\\}\\)]\\s*\\.first"
let firstRanges = file.match(pattern: pattern, with: [.identifier])
let contents = file.contents.bridge()
let structure = file.structure
let violatingLocations: [Int] = firstRanges.flatMap {
guard let bodyByteRange = contents.NSRangeToByteRange(start: $0.location,
length: $0.length),
case let firstLocation = $0.location + $0.length - 1,
let firstByteRange = contents.NSRangeToByteRange(start: firstLocation,
length: 1) else {
return nil
}
return methodCall(forByteOffset: bodyByteRange.location - 1, excludingOffset: firstByteRange.location,
dictionary: structure.dictionary, predicate: { dictionary in
guard let name = dictionary.name else {
return false
}
return name.hasSuffix(".filter")
})
}
return violatingLocations.map {
StyleViolation(ruleDescription: type(of: self).description,
severity: configuration.severity,
location: Location(file: file, byteOffset: $0))
}
}
private func methodCall(forByteOffset byteOffset: Int, excludingOffset: Int,
dictionary: [String: SourceKitRepresentable],
predicate: ([String: SourceKitRepresentable]) -> Bool) -> Int? {
if let kindString = (dictionary.kind),
SwiftExpressionKind(rawValue: kindString) == .call,
let bodyOffset = dictionary.bodyOffset,
let bodyLength = dictionary.bodyLength,
let offset = dictionary.offset {
let byteRange = NSRange(location: bodyOffset, length: bodyLength)
if NSLocationInRange(byteOffset, byteRange) &&
!NSLocationInRange(excludingOffset, byteRange) && predicate(dictionary) {
return offset
}
}
for dictionary in dictionary.substructure {
if let offset = methodCall(forByteOffset: byteOffset, excludingOffset: excludingOffset,
dictionary: dictionary, predicate: predicate) {
return offset
}
}
return nil
}
}