-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OwnPad does not allow sharing folders of Etherpads #134
Comments
Thanks for the feedback. Can you confirm that sharing a single Etherpad document publicly works as expected please? |
Yes, can confirm that. |
Btw, the current workaround i suggested $users is using the link_editor app to add direct links to the concerned etherpads into the to-be-shared folder, while storing the actual pads elsewhere (level above, e.g.). Kind of gives the same UX (with some extra steps for the folder owner, but at least for those clicking on the folder); |
Note: Just noticed that there is a typo in the nextcloud version; It is actually 27.1.2; Updated the first entry accordingly. |
I got this problem too. ownpad 0.10.0 & nextcloud 28.0.2 |
Hello, I also have the problem (ownpad 0.9.5 / Nextcloud 26.0.4). Sharing a folder with .pad files and someone trying to access one of these files receives the error: In Nextcloud.log, I see the message:
I noticed the problem comes from the file ./lib/Service/OwnpadService.php. The var $content passed as a parameter to the function parseOwnpadContent is empty.
And then, later on, when testing the Url with a regexp, it returns false and throws the error:
If I manually set the $url var to an url found in a .pad file, I can open and edit it. But I couldn't find why this $content param is empty. |
One thing I noticed that could help understand why we have this (or not): The $file param from the function has the correct filename, but not the correct path. Maybe it's normal, but as the pad file is at the root of the public share, the $file var has the value: Maybe it can't find the file because it looks at the wrong place for the file. AS the nextcloud.log shows, it looks for the file here: And that's not the right folder for this file. |
When sharing a folder (publicly) that has multiple etherpad links in it, nextcloud (27.1.2) with ownpad (0.9.5) does not support this. The error log shows:
When accessing the shared folder anonymously:
When accessing the shared folder while having a user session but via the public share link:
Sharing and opening individual pads works.
I suspect that the implementation for public shares uses a different way of accessing files, and only the internal version has been appropriately hooked/loads the right MIME options.
To reproduce:
The text was updated successfully, but these errors were encountered: