Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Double load global.lua #4770

Open
4 tasks done
ArturKnopik opened this issue Jul 24, 2024 · 0 comments
Open
4 tasks done

[Bug]: Double load global.lua #4770

ArturKnopik opened this issue Jul 24, 2024 · 0 comments
Labels
bug An issue describing unexpected behavior of code needs-confirmation not confirmed by a developer yet

Comments

@ArturKnopik
Copy link
Contributor

ArturKnopik commented Jul 24, 2024

By submitting this bug issue, you agree to the following.

  • This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
  • This issue is reproducible without changes to the C++ code in this repository
  • This bug has not been resolved in master branch
  • There is no existing issue for this bug already

Does this bug crash tfs?

no

Server Version

1.7 (Master)

Operation System

all (listed below)

OS Description

No response

Bug description

global.lua is loaded twice by C++ code

Possible Pull Requests which are to blame

c5426f0

Steps to reproduce

Run engine
Check logs

Loading vocations
Loading items... OTB v3.65.62
Loading script systems
Using LuaJIT 2.1.0-beta3 << FIRST CALL*
Loading lua libs
Using LuaJIT 2.1.0-beta3 << SECOND CALL*
NpcLib loaded
Loading lua scripts
Loading monsters
Loading lua monsters
Loading lua npcs
Loading outfits

  • global.lua is loading dofile('data/lib/lib.lua') that loads dofile('data/lib/debugging/lua_version.lua')

Actual Behavior

global.lua loaded twice.

Expected Behavior

global.lua loaded once.

Backtrace

No response

Code

https://github.com/otland/forgottenserver/blob/973855c3e0a60461117b55f248ad14bab6630780/src/scriptmanager.cpp#L48C2-L48C59
https://github.com/otland/forgottenserver/blob/973855c3e0a60461117b55f248ad14bab6630780/src/npc.cpp#L28C1-L29C1

@ArturKnopik ArturKnopik added bug An issue describing unexpected behavior of code needs-confirmation not confirmed by a developer yet labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected behavior of code needs-confirmation not confirmed by a developer yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant