From 6131f43bbb92f464479d5e63c7f21c497a46ad41 Mon Sep 17 00:00:00 2001 From: Brian Austin Date: Wed, 24 Jul 2024 21:15:33 -0400 Subject: [PATCH] Better handling for empty referer --- app/models/feedback_reporters/support_reporter.rb | 2 +- spec/models/feedback_reporters/support_reporter_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/feedback_reporters/support_reporter.rb b/app/models/feedback_reporters/support_reporter.rb index 8cd5afaf55..6d57d7845f 100644 --- a/app/models/feedback_reporters/support_reporter.rb +++ b/app/models/feedback_reporters/support_reporter.rb @@ -16,7 +16,7 @@ def custom_zoho_fields # The Zoho field supports at most 255 characters. That _should_ be enough, but technically # we support ludicrously long URLs because searches can do that. In those cases, just get the # first 255 characters. - sanitized_url = referer ? referer[0..254] : "Unknown URL" + sanitized_url = referer.present? ? referer[0..254] : "Unknown URL" { "cf_archive_version" => site_revision.presence || "Unknown site revision", "cf_rollout" => rollout.presence || "Unknown", diff --git a/spec/models/feedback_reporters/support_reporter_spec.rb b/spec/models/feedback_reporters/support_reporter_spec.rb index 15616f1bd8..90180eebbf 100644 --- a/spec/models/feedback_reporters/support_reporter_spec.rb +++ b/spec/models/feedback_reporters/support_reporter_spec.rb @@ -120,7 +120,7 @@ end it "returns a hash containing a blank string for referer" do - expect(subject.report_attributes.dig("cf", "cf_url")).to eq("") + expect(subject.report_attributes.dig("cf", "cf_url")).to eq("Unknown URL") end end