Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on LIBPLCC #120

Closed
StoneyJackson opened this issue Apr 21, 2024 · 1 comment · Fixed by #122
Closed

Remove dependency on LIBPLCC #120

StoneyJackson opened this issue Apr 21, 2024 · 1 comment · Fixed by #122
Labels

Comments

@StoneyJackson
Copy link
Member

Bash and Python scripts can find their location and then use relative paths to access what they need.

Advantages:

Disadvantages:

  • Adds logic to scripts to determine the location of desired resources based on the script's location.

Neutrals:

  • Install still requires updating PATH. (But this would go away in PyPI #119 .

Impact:

  • Docker users: none
  • GitPod users: their config would have a useless LIBPLCC environment variable that could be removed.
  • Native users: they would have a useless LIBPLCC environment variable that could be removed.
StoneyJackson added a commit that referenced this issue Apr 22, 2024
BREAKING CHANGE:

plcc is now a Python package, and plcc.py has been removed.
So plcc.py can no longer be called directly like this

    python3 path/to/plcc.py grammar

Instead, use plcc like this

    plcc grammar

---

This commit restructures the PLCC codebase into that of a
conventional Python project. This should make it easier to
redesign the internal structure of PLCC, making it easier to
maintain and add new functionality. It should also help us
prepare to distribute PLCC through PyPI, making it easier
to install. Here is a summary of changes.

- Convert plcc.py into python package plcc
- Remove environment variable LIBPLCC
- Move src/Std/ to src/
- Move lib/jackson to src/lib/jackson
- Move src/ to plcc/bin/
- Pull common functionality of scripts into plcc/bin/__init__.bash

---

Related Issues

- Related to #119
- Closes #121
- Closes #120
StoneyJackson added a commit that referenced this issue Apr 28, 2024
BREAKING CHANGE:

plcc is now a Python package, and plcc.py has been removed.
So plcc.py can no longer be called directly like this

    python3 path/to/plcc.py grammar

Instead, use plcc like this

    plcc grammar

---

This commit restructures the PLCC codebase into that of a
conventional Python project. This should make it easier to
redesign the internal structure of PLCC, making it easier to
maintain and add new functionality. It should also help us
prepare to distribute PLCC through PyPI, making it easier
to install. Here is a summary of changes.

- Convert plcc.py into python package plcc
- Remove environment variable LIBPLCC
- Move src/Std/ under src/plcc (the PLCC Python package)
- Move lib/jackson under src/plcc (the PLCC Python package)
- Pull common functionality of scripts into common.bash

---

Related Issues

- Related to #119
- Closes #121
- Closes #120
Copy link

🎉 This issue has been resolved in version 8.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant