Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build out validation for facilityService #338

Open
5 tasks
ermish opened this issue Oct 30, 2023 · 0 comments
Open
5 tasks

Build out validation for facilityService #338

ermish opened this issue Oct 30, 2023 · 0 comments
Assignees
Labels
backend enhancement New feature or request

Comments

@ermish
Copy link
Collaborator

ermish commented Oct 30, 2023

Summary

We want to validate all user input. We have specific validation methods for each type of user input.

In the facility service, some of the methods are created, but the validation is not filled out yet. Feel free to add/update validation methods as needed

Requirements

  • Come up with the essential list of rules for each user input field. (example: nameEn should be less than 64 chars.)
    • use your best judgement and practical knowledge of rules. Consider what is a realistic min/max value, should it be null/undefined, negative/positive numbers,
  • when comparing strings, we should use .toLowerCase() to ignore casing mismatches.
    • Let's update the values that are saved to always be lowercase as well.
  • Write up the rules and add missing codes. (these are used by the client-side to determine what error message to show the user based on their localization)
  • Create a new facilityValidation file in validation folder

Dependencies

@ermish ermish added enhancement New feature or request backend labels Oct 30, 2023
@ermish ermish moved this to [High Priority] Backlog in MVP Milestones Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants