Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our api calls in stores to use the ServerResponse type to display error messages and our retry call #878

Open
3 tasks done
NabbeunNabi opened this issue Oct 30, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request pair programming This is a ticket that is good to pair with someone on

Comments

@NabbeunNabi
Copy link
Contributor

NabbeunNabi commented Oct 30, 2024

Problem

Some of the ways that our calls are being done to the backend are outdated. There was an updated way with auto retry that was created in the file utils/graphql.ts named graphQLClientRequestWithRetry. We should be using this to call the backend as it allows for auto retry before created an error. These calls also should return the new ServerResponse type in order for us to display error messages in the future to the users.

Success

The calls are updated, with the return of the ServerResponse type.

Requirements

  • Update the API calls to use the graphQLClientRequestWithRetry
  • The API calls return the new ServerResponse type
  • The calls still are successful with all the tests passing
@NabbeunNabi NabbeunNabi added enhancement New feature or request pair programming This is a ticket that is good to pair with someone on labels Oct 30, 2024
@NabbeunNabi NabbeunNabi self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pair programming This is a ticket that is good to pair with someone on
Projects
None yet
Development

No branches or pull requests

1 participant