Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint.config.js #982

Open
gminetoma opened this issue Jan 27, 2025 · 5 comments
Open

fix: eslint.config.js #982

gminetoma opened this issue Jan 27, 2025 · 5 comments
Assignees
Labels
bug Something isn't working code quality

Comments

@gminetoma
Copy link
Contributor

Problem

Our eslint.config.js is misconfigured, causing some rules not to be applied. This is problematic as it leads to coding inconsistencies in our codebase.

Success

Fix eslint.config.js and refactor all files after resolving the issue.

Implementation Notes

The root of the problem is as follows:

Image

  • The path is incorrect.
  • The tseslint.configs.recommended is an array, so it's either in the wrong place or using the wrong property.

After correcting these issues, we will encounter numerous ESLint errors:

Image

Image

@gminetoma gminetoma added bug Something isn't working code quality labels Jan 27, 2025
@gminetoma gminetoma self-assigned this Jan 27, 2025
@gminetoma
Copy link
Contributor Author

@ermish

After fixing the ESLint configuration, I noticed numerous no-console errors. I came across a comment from you mentioning that we should use a logger instead of console.

Do you have a logger preference?

@gminetoma
Copy link
Contributor Author

@ermish @theyokohamalife

What should we do with no-alert errors?

Image

@ermish
Copy link
Contributor

ermish commented Jan 31, 2025

Hmmm do you have a branch where I can see them running?
For right now, console is the best option since don't have logging set up yet.
For alerts I don't think we have any places we should be showing it to the user so those probably need to be removed

@ermish
Copy link
Contributor

ermish commented Jan 31, 2025

Future logging is something I can make a ticket for if you/someone wants to work on it!

@gminetoma
Copy link
Contributor Author

@ermish

https://github.com/ourjapanlife/findadoc-web/tree/fix%2Feslint-config

I can work on it! Please create the ticket and assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants