From 5af24c88d69b24c12065674d6eba0d47903c6d1f Mon Sep 17 00:00:00 2001
From: Ou <orongxing@gmail.com>
Date: Fri, 22 Nov 2024 01:08:49 +0800
Subject: [PATCH] fix: cannot dnd in firefox

---
 src/components/column/card.tsx           | 4 ++--
 src/components/common/dnd/useSortable.ts | 6 ++----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/components/column/card.tsx b/src/components/column/card.tsx
index 9274292..94b20ca 100644
--- a/src/components/column/card.tsx
+++ b/src/components/column/card.tsx
@@ -140,10 +140,10 @@ function NewsCard({ id, setHandleRef }: NewsCardProps) {
             className={$("btn", isFocused ? "i-ph:star-fill" : "i-ph:star-duotone")}
             onClick={toggleFocus}
           />
+          {/* firefox cannot drag a button */}
           {setHandleRef && (
-            <button
+            <div
               ref={setHandleRef}
-              type="button"
               className={$("btn", "i-ph:dots-six-vertical-duotone", "cursor-grab")}
             />
           )}
diff --git a/src/components/common/dnd/useSortable.ts b/src/components/common/dnd/useSortable.ts
index 79fe311..7ce5fcb 100644
--- a/src/components/common/dnd/useSortable.ts
+++ b/src/components/common/dnd/useSortable.ts
@@ -37,10 +37,8 @@ export function useSortable(props: SortableProps) {
     if (handleRef && nodeRef) {
       const cleanup = combine(
         draggable({
-        // use custom drag preview
-          element: handleRef,
-          // element: ref,
-          // dragHandle: handleRef,
+          element: nodeRef,
+          dragHandle: handleRef,
           getInitialData: () => ({ id: props.id, instanceId }),
           onGenerateDragPreview({ nativeSetDragImage, location }) {
             setCustomNativeDragPreview({