Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Checkboxes do not work in firefox again #431

Closed
MonstraG opened this issue Apr 16, 2021 · 6 comments
Closed

Checkboxes do not work in firefox again #431

MonstraG opened this issue Apr 16, 2021 · 6 comments
Labels
bug Something isn't working more-information-needed

Comments

@MonstraG
Copy link

Checkboxes do not check in firefox.

Version
React 17.0.2
Rich-markdown-editor 11.6.4

Gif
Left: chrome, right: firefox. Both most recent.
1

Desktop (please complete the following information):

  • OS: Win 10
  • Browser Firefox
  • Version 88.0b9
@MonstraG MonstraG added the bug Something isn't working label Apr 16, 2021
@tommoor
Copy link
Member

tommoor commented Apr 20, 2021

I cannot reproduce this behavior, my guess is you're hitting this issue with the wrong version of prosemirror-transform installed:

#427

@MonstraG
Copy link
Author

MonstraG commented Apr 20, 2021

I've deleted package.lock and node_modules, added "prosemirror-transform": "1.2.5", to dependencies, and run npm install, it still doesn't work. Gonna make a repro now

@MonstraG
Copy link
Author

MonstraG commented Apr 20, 2021

I'm realising I should have also said this:
npm is v7.7.6 and gives following on clear npm install:

npm WARN ERESOLVE overriding peer dependency
npm WARN Found: [email protected]
npm WARN node_modules/prosemirror-tables
npm WARN   prosemirror-tables@"^1.1.1" from [email protected]
npm WARN   node_modules/rich-markdown-editor
npm WARN     rich-markdown-editor@"^11.6.4" from the root project
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer prosemirror-tables@"^0.9.1" from [email protected]
npm WARN node_modules/prosemirror-utils
npm WARN   prosemirror-utils@"^0.9.6" from [email protected]
npm WARN   node_modules/rich-markdown-editor

I'm running NextJs v10.1.3.
Although I've seen an issue about SSR with nextjs, this functionality shouldn't be connected with SSR anyways.

And here is the repro:
https://github.com/MonstraG/RichMdEditorRepro

There is nothing to it really, it's just editor in a page. I've added console.log() in onChange and you can see that firefox doesn't trigger onChange and Chrome does.

@tommoor
Copy link
Member

tommoor commented Apr 25, 2021

Unfortunately I'm just unable to reproduce on Firefox on Mac, it may be a Windows thing – but without being able to repro there can't be a fix.

@tomershvueli
Copy link

FWIW, I'm also seeing this issue on a Mac. Node 14.15.4.

@MonstraG
Copy link
Author

MonstraG commented Jun 20, 2021

I don't know if its related, but, in Chrome, when I hold LMB over checkbox, draggable="true" appears on <li>.
image
But in Firefox, not just draggable, but also contenteditable=false appears
image

@tommoor tommoor closed this as completed Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working more-information-needed
Projects
None yet
Development

No branches or pull requests

3 participants