Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in (v-add-letsencrypt-domain) resulting msg Error: Let's Encrypt validation status // without code #2251

Open
matjaz-cas opened this issue Jun 1, 2022 · 1 comment

Comments

@matjaz-cas
Copy link

matjaz-cas commented Jun 1, 2022

The problem:

Click on web profile > EDIT > check SSL Support (Lets Encrypt Support)

In some cases (only one account so far), when I clicked SAVE I got message saying (Error: Let's Encrypt validation status) - without any status code at the end or info on what is the cause of this validation error.

After I checked the logs I saw that in some cases json returned from letsencrypt API was not parsed correctly so it resulted in error without any error code identification.

I checked the file "v-add-letsencrypt-domain" the problem was in STEP 3, when parsing url= parameter line:172 was not parsing correctly.
I changed from:
url=$(echo "$answer" |grep -A3 $proto |grep url |cut -f 4 -d \")
to
url=$(echo "$answer" |grep -A2 $proto |grep url |cut -f 4 -d \")

after that it worked, i checked parsing of other already working letsencrypt accounts and it also worked from them, so this change didn't break it.. anyways I solved it and changed it back to -A3.. maybe someone check this?

@pschiffe
Copy link

same for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants