Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

about naming, consistency, name clashes, module organisation #7

Open
rvion opened this issue Mar 25, 2017 · 2 comments
Open

about naming, consistency, name clashes, module organisation #7

rvion opened this issue Mar 25, 2017 · 2 comments

Comments

@rvion
Copy link

rvion commented Mar 25, 2017

I love OutWatch's overall design, but have some issues with consistency, modules organisation, and naming clashes (I saw the latests re-organisation commits, but I think there is more to discuss)

Purescript

names like div are really annoying to use because they clash with prelude.
name like tpe are also annoying to use because they are harder to remember

would it make sense to follow lucid design and prefix or postfix everything with an _ ?

  • no more Names that conflict with base (div, id, head, map) -> only: div_; ul_, id_, etc.
  • no more names that are keywords, (type -> tpe or type_ or ..., class -> cls or class or ...) -> only class_, type_, etc.

it could also help adding back an global OutWatch that reexport most useful functions

(to see some more lucid examples, github link is here: https://github.com/chrisdone/lucid)

@LukaJCB
Copy link
Member

LukaJCB commented Mar 26, 2017

Hey @rvion thanks a lot for bringing this up! :)

I can definitely see the issues with the naming clashes in prelude and I'm not happy with it either.
However I'm not a hundred % convinced yet, that this is the answer. I can't really point to exactly why, but to me it's not pleasing solution yet.

Maybe, though, we could support both? Then you can import the module you like and go with that if you value consistency.

@rvion
Copy link
Author

rvion commented Mar 26, 2017

indeed, that's what I've been experimenting with, I'll share that very soon :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants