Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronizations should be visible in the Provisioning Tasks list #3

Closed
oveits opened this issue Oct 2, 2015 · 3 comments
Closed

Comments

@oveits
Copy link
Owner

oveits commented Oct 2, 2015

All background jobs including the synchronization jobs should be visible in a tasks list. Today, only provision methods :create and :delete are seen.

@oveits
Copy link
Owner Author

oveits commented Oct 2, 2015

Implementation idea:

  1. add :synchronize as provision method
    or
  2. generalize the provisioning tasks to general "tasks" or "tickets"
  • provisionings (a.k.a. provisioning tasks) then are a dependent model
  • readings could be another dependent model
  • synchronizations could be a third dependent model

In order to decide between 1) and 2), I need to evaluate, which method is DRYer.

@oveits
Copy link
Owner Author

oveits commented Mar 1, 2016

Implemented in e697c3d (see this diff) like follows:

  • Added new model GeneralJob based on ActiveJob (under app/jobs)
  • save it on the database via provisioning = Provisioning.new(...).save (otherwise it will be lost, once the job is finished)
  • instead of delivering the provisioning via provisioning.deliver (as I do it with provision/de-provision/read), I run it via job = GeneralJob.perform_later(self, "synchronizeSynchronously") in app/models/provisioningobject.rb: synchronize method.

TODO:

@oveits
Copy link
Owner Author

oveits commented Mar 1, 2016

Feature is implemented in e697c3d. I will close the request. Implementation improvements will be handled in other request (e.g. issue #45).

@oveits oveits closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant